[New LinOp] Implementation of a SubSampling operator.

pyxu-org / pyxu

Modular and scalable computational imaging in Python with GPU/out-of-core computing.

https://pyxu-org.github.io/

MIT License

117 stars 17 forks source link

[New LinOp] Implementation of a SubSampling operator. #32

Closed AdriaJ closed 2 years ago

AdriaJ commented 2 years ago

I have tested this operator and its adjoint with Numpy and Dask arrays, but not with cupy arrays as I don't have a GPU.

I have not been able to squash the 17 commits into one, as they are spread within the long history of other commits made on v2-dev. Please squash them when merging the PR.

SepandKashani commented 2 years ago

Thank you for this addition. The code as-is is functional but lacking in a few directions:

no test suite
does not allow sub-sampling N-dimensional inputs
is stated as module-specific, while this can be relaxed
doesn't override methods such as gram()/svdvals()/etc from LinOp. (Large performance gains possible)

I will nevertheless accept the PR. Follow-up commits on my behalf expand this implementation as stated above and will also be pushed shortly.