search

pyxu-org / pyxu

Modular and scalable computational imaging in Python with GPU/out-of-core computing.
https://pyxu-org.github.io/
MIT License
117 stars 17 forks source link

V2 dev daniele #34

Closed dhamm97 closed 1 year ago

dhamm97 commented 2 years ago

Implementation of following penalty functionals:

dhamm97 commented 1 year ago

The indicator balls do not pass the test_math_lipschitz tests. I believe this is due to some “bug” in the test coming from the fact that if two points don’t belong to the ball, then in the lipschitz estimation the lhs is np.inf-np.inf=nan, the rhs is np.inf (Lipschitz constant set to np.inf), and since nan<np.inf returns False the test fails.

SepandKashani commented 1 year ago

@dhamm97 I had to fix a few things after merging, but otherwise not bad for a first PR. Please check my commit messages for some high-level feedback on your work. We can further discuss during the Pycsou dev meeting.

dhamm97 commented 1 year ago

@SepandKashani great, thank you very much! I will definitely check your comments.