[opt] Replaced ProxAdam by Adam.

pyxu-org / pyxu

Modular and scalable computational imaging in Python with GPU/out-of-core computing.

https://pyxu-org.github.io/

MIT License

117 stars 17 forks source link

[opt] Replaced ProxAdam by Adam. #51

Closed Dicedead closed 1 year ago

Dicedead commented 1 year ago

ProxAdam was found to be slow, too slow for realistic purposes, yet there is value in the ability to handle stochastic optimization. Hence this PR replaces the ProxAdam implementation by Adam.

Changes:

Inner loop of m_step handling proximable regularizer removed.
m_step, API, tests and documentation adapted accordingly.

SepandKashani commented 1 year ago

@Dicedead Thank you; the PR is accepted (with minor corrections which will follow).