pyxu-org / pyxu

Modular and scalable computational imaging in Python with GPU/out-of-core computing.
https://pyxu-org.github.io/
MIT License
117 stars 17 forks source link

[abc/solver] change default wriback_rate behavior to 'no writeback' #59

Closed joanrue closed 7 months ago

joanrue commented 7 months ago

This PR changes the default behavior of solver which would always write to disk the solution when the stopping criterion was met. In the suggested implementation, by default there is no writting to disk at all. The previous behavior (only writeback at when stop_crit is reached) is reproduced using writeback_rate = -1. Equivalently to before, writeback_rate defines the number of iterations after which the solution is saved to disk.

SepandKashani commented 7 months ago

@joanrue Thanks for the changes. I updated the test suite accordingly: all good to merge.