nus-pe-script
commented
1 year ago Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Able to have a person with a different name, but with the same email, same github profile, and same name
I believe that the duplication checking should not be used with respect to one's name, but with respect to one's email and github and phone instead.
[original: nus-cs2103-AY2223S2/pe-interim#4133] [original labels: severity.Low type.FeatureFlaw]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
This bug report is rejected, as different contacts may share the same contact details as they may want to be contacted through the same avenue, or use the same accounts. Furthermore, this is common practice in many contact management software, and as such, is the convention for such applications.
For example, different contacts may wish to be contacted through the same house phone, or prefer to be reached through the same email, or use a single github profile for collaborative work.
Also, we would like to request that the tester clarify what he means by "Able to have a person with a different name ... and same name", as there is a conflict in the statement.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
Adding/Edit duplicates is only checked for the the name attribute but not for unique fields such as phone and github username as shown.
Maybe, this could be specify in the DG and UG instead to allow the user to know what fields can be a duplicate. Overall, good job for prevent duplicates for being added!