search

pzavolinsky / elmx

A tiny precompiler that takes an Elm program with embedded HTML and desugars the HTML into elm-html syntax. Elmx is to Elm what React's JSX is to Javascript
MIT License
353 stars 11 forks source link

Use Html.node instead of element name #12

Closed freekh closed 7 years ago

freekh commented 7 years ago

Our designers want to use Html elements that are not necessarily in Html. AFAICS the signature of Html is the same for all typed elements (Html.span, Html.div, ...) so it should be fine.

pzavolinsky commented 7 years ago

Hi @freekh , thanks for this contrib!

It's merged to master and published as version 2.0.0 (bumped the major since the new Elm code is expected to generate many differences in peoples' repos).

If there is any controversy around using Html.node for the most common tags I'm more than willing to whitelist the ones that should be using Html.<node> just like we do for keyed. (maybe we'll revisit this comment in the future).

Thanks again, Cheers!

freekh commented 7 years ago

Hi @pzavolinsky and thanks!

Yeah, that makes sense :)