False positive with path aliases and sub-folders

[ilyin371]

Steps to reproduce with example\with-paths:

1. Move utils\src\calculations.ts into a new sub-folder utils\src\sub\calculations.ts.
2. Update import statement in math.ts to import {calculations} from 'utils/sub/calculations';
3. Run ts-unused-exports example\with-paths\tsconfig.json
4. utils\src\sub\calculations.ts: calculations is falsely reported as unused.

[mrseanryan]

Thank you for reporting it

[mrseanryan]

hi @ilyin371 - I cannot repro this issue.

I pushed a branch where I try the above, but it seems to work OK for me!

branch = scratch/path-alias-issue-154

cd example/with-paths
node ../../bin/ts-unused-exports tsconfig.json

OUTPUT:

.../example/with-paths/math.ts: add1

(calculations.ts does NOT appear as unused)

[mrseanryan]

@ilyin371 is there something about your tsconfig.json file ? :thinking:

[mrseanryan]

My tsconfig.json is:

{
  "compilerOptions": {
    "baseUrl": ".",
    "target": "es5",
    "noEmit": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "moduleResolution": "node",
    "paths": {
      "utils": ["utils/src"],
      "utils/*": ["utils/src/*"]
    }
  }
}

[kevinoliveira]

same issue here, I can confirm it's due to path aliases. i can create a reproducible environment later today.

PS: awesome project

[mrseanryan]

@kevinoliveira if you can post example or even better make a fork with working example, that would be great!

[kevinoliveira]

@mrseanryan i hope this can be useful https://github.com/kevinoliveira/ts-unused-exports-issue-154-example

[mrseanryan]

cheers @kevinoliveira

I think it is related to the #customAlias part:

import { sayHelloWorldInJapanese } from "#customAlias/helpers";

This helps a lot!

[mrseanryan]

@ilyin371 @kevinoliveira have a fix here:

https://github.com/pzavolinsky/ts-unused-exports/pull/176

If you have the time, it would great to get feedback before we merge and release.

Branch is:

fix/path-aliases-and-sub-folders

[mrseanryan]

fixed in 7.0.0

[kevinoliveira]

@mrseanryan sorry for the delay, there are no more false positives.

[aryzing]

@mrseanryan has it been resolved? I seem to be having the same issue with the latest version.

In the repro below, there's a single export foo being reported as unused, despite it clearly being used, https://github.com/aryzing/practice-ts-unused-exports

[aryzing]

Seems to be related to the fact that the file imported is the index file. I've noticed that in the past there have been several issues related to index-related false positives, so may be a regression?

• https://github.com/pzavolinsky/ts-unused-exports/issues/220
• https://github.com/pzavolinsky/ts-unused-exports/issues/222

[mrseanryan]

@aryzing thanks for reporting. This is about the @ part of the import which is not something supported.

import { foo } from "@foo/index";

Opening as a new issue ...

[mrseanryan]

UPDATE:

Ineed, the problem is the file being imported is index Another very similar file other works OK.

but at this point its simpler for me to manage, as a separate related issue.