pzavolinsky / ts-unused-exports

ts-unused-exports finds unused exported symbols in your Typescript project
MIT License
749 stars 49 forks source link

Add CI build (travis?) #69

Closed mrseanryan closed 5 years ago

mrseanryan commented 5 years ago

It could be nice to add CI builds, to auto lint and test branches.

Currently, all such checks are done manually, which is not optimal and can be a bit error-prone.

Also, we could test against multiple Node versions, which is something that is currently not really practical.

@pzavolinsky I've used travis on quite a few projects. It seems pretty simple.

If you like to use travis, then my understanding is that as the repository owner, you need to be the one to grant travis hooks access to this repo.
After that, I believe I can configure it.

The idea would be to first add a simple CI build, that lints, runs unit + itests.

Maybe later, we can make a 'publish' build.

mrseanryan commented 5 years ago

related: could add a coverage badge and build passes badge etc.

pzavolinsky commented 5 years ago

I've added Travis CI here: https://github.com/pzavolinsky/ts-unused-exports/pull/71

And you can check build status here: https://travis-ci.com/pzavolinsky/ts-unused-exports

pzavolinsky commented 5 years ago

I'm not sure how to add a CC badge, but there must be an easy way to do it.

mrseanryan commented 5 years ago

Nice!  I'll make a PR with badges that seem useful, so you can review.  For CC badge - it is easy but perhaps could be good to wait until  coverage is higher.  You link the repo to coveralls.ioAnd the badge is like: [![Coveralls](https://img.shields.io/coveralls/mrseanryan/tslint-folders.svg)](https://coveralls.io/github/mrseanryan/tslint-folders) I'm hoping to add more tests, to up the coverage...  Sean

Sent from Yahoo Mail on Android

On Mon, 4 Nov 2019 at 4:29, Patricio Zavolinskynotifications@github.com wrote:
I'm not sure how to add a CC badge, but there must be an easy way to do it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

pzavolinsky commented 5 years ago

For CC badge - it is easy but perhaps could be good to wait until coverage is higher.

:+1: