pzivich / Delicatessen

Delicatessen: the Python one-stop sandwich (variance) shop 🥪
https://deli.readthedocs.io/en/latest/index.html
MIT License
22 stars 2 forks source link

v1.1 #21

Closed pzivich closed 1 year ago

pzivich commented 1 year ago

v1.1 update

To-do list:

pzivich commented 1 year ago

One problem with the use of additive_design_matrix is that if only the number of knots are given, then it manually creates from the input. However, this can conflict when creating a design matrix for plots. The knot locations will be different in this second version, which will generate an incorrect plot.

I need to think of a way to prevent this (force users to provide the knot locations?)