pzivich / Delicatessen

Delicatessen: the Python one-stop sandwich (variance) shop 🥪
https://deli.readthedocs.io/en/latest/index.html
MIT License
22 stars 2 forks source link

[BUG] Powell Hybrid error tolerance specification #29

Closed pzivich closed 1 year ago

pzivich commented 1 year ago

Expected behavior The tolerance parameter in MEstimator.estimate is expected to control the error tolerance for the corresponding key-word root-finding algorithms. However, this is not the case for the Powell hybrid method ('hybr').

Describe the bug On line 482, the xtol is set. But this is incorrect. Instead, maxfev per the SciPy documentation here. Thankfully this bug only leads to the hybrid method using the default SciPy error tolerance. Therefore, this bug should have minimal impacts on analyses using previous versions.

Relevant error output None

Versions:

To Reproduce N/A

Additional context N/A