pzivich / zEpid

Epidemiology analysis package
http://zepid.readthedocs.org
MIT License
141 stars 33 forks source link

Change IPTW API #102

Closed pzivich closed 5 years ago

pzivich commented 5 years ago

Lately I have been considering changing the IPTW procedure to more closely adhere to the other estimators. Specifically, IPTW only calculates the weights for the user. It then passes them to the user and assumes they know how to apply them afterwards. I made this decision a long time ago, but am reconsidering.

The API change would be something like the following;

pzivich commented 5 years ago

Unfortunately, this will be slightly more complicated than I would like. For the all the generalizability/transportability tools for observational data, it takes input of the weights. This aligns with the current API of v0.7.0

I still think estimating marginal structural models for the user is the way forward. To solve this issue, the user could extract the weights from the updated IPTW then supply them to the generalizability tools. I will need to think about this some more...

pzivich commented 5 years ago

Closed via #108