pzl111 / pe

0 stars 0 forks source link

Incorrect comamnd error #24

Open pzl111 opened 10 months ago

pzl111 commented 10 months ago

image.png

When i type edit 1 dt/29-02-2023 10:00, the error given was that i had a wrong command error. but the command is indeed in the correct format, just that there is no 29 feb for 2023. Not a functionality bug hence not very low severity.

soc-se-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect error message for date time

When putting in days that exceed the number of days for a month (e.g. days 30, 31, for February and day 31 for April), the error message given says the date is incorrectly formatted rather than being a date that is not possible to receive.

image.png

This is medium severity as users may mistype a month with a shorter number of days and have no clue what the issue is with the command they have put in.


[original: nus-cs2103-AY2324S1/pe-interim#3672] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Why Low Severity & FeatureFlaw

You are right, our error message for this should have been more specialised! Thanks for pointing this out. However, we believe this to be a very minor issue, given that this would be rare and would only cause a minor inconvenience, especially since a error message is already given to them which would be an indicator that there is an issue with the dateTime format, even if not explicitly stated. We thus downgraded this issue from a Severity.Medium to a Severity.Low.

telegram-cloud-photo-size-5-6253483417203228353-x.jpg

On another note, this would constitute a specialised error message instead of a generalised one for all invalid date formats - and we acknowledge that, thus we believe that this would be a FeatureFlaw and not a FunctionalityBug, since these inputs are rejected since they are invalid, and our feature still works as expected.

telegram-cloud-photo-size-5-6260244284137650135-x.jpg

Why NotInScope

We considered implementing this as it is a specialised error message for users, but we decided that there were more important features to fix / work on, given that we already provide a message to users to indicate that there is something wrong with the dateTime they have input. If there was another sprint, we would probably have gone further to specialise our error messages - which would include a separate workflow specifically for invalid dates that match the given formatting, and that is why we put this as NotInScope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]