search

pzl111 / pe

0 stars 0 forks source link

Long transaction names get truncated with ellipsis then wrap #25

Open pzl111 opened 11 months ago

pzl111 commented 11 months ago

image.png

I think this is a minor cosmetic issue, since it can be displayed on the right. However the user when navigating other transactions, cant see this properly, hence i think it is still a bug. The app could have considered wrapping. The amount would not be visisble too.

nus-pe-bot commented 11 months ago

Team's Response

The get command is designed for these scenarios, see duplicated issue for more information

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Long names don't display properly

Running the command at n/longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong type/expense amt/30

Results in the following UI: image.png

This makes it hard for the user to find out what the transaction actually is

[original: nus-cs2103-AY2324S1/pe-interim#3677] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi, thank you for the feedback.

We have decided to reject this issue, as not only is the issue unclear, we are also unable to replicate the issue.

Firstly, entering the input command

at n/longlonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglonglong type/expense amt/30

as specified by the tester into our app results in the following output of successful transaction addition.

image.png

The reason for the shown DateTime error is unclear, as the input transaction is considered valid and therefore it is added to UniCa$h with a confirmation message shown that the transaction is added. Thus, we are not able to replicate the shown error.

Secondly, it is not clear what is meant by "Results in the following UI" and also "makes it hard for the user to find out what the transaction actually is". In the UI shown, the transaction is displayed as entered and shown by the user. Furthermore, the get command is provided to retrieve the full name of a transaction, and as we have mentioned in our UG, we provided this command so that transaction names are not subject to arbitrarily short lengths.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The duplicate bug is somewhat similar in that it has truncation in transaction name when run, however they had the issue of DateTime error, which is not what my bug report is about.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** The groupd could have opted for wrapping of text in the GUI instead of truncation. I would understand if it stretches to more than 3 lines on the transaction list at the left side then they truncate it. But truncating it for 1 line is an unnecessary restriction.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.VeryLow`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]