pzl111 / pe

0 stars 0 forks source link

Entering 24:00 is a correct date format but mentions wrong command format #29

Open pzl111 opened 10 months ago

pzl111 commented 10 months ago

typing edit 1 dt/29-02-2000 24:00 tells me this:

image.png

but it is correct format, just that 24:00 does not exist.

nus-se-bot commented 9 months ago

Team's Response

Thank you for your feedback. 24:00 is not a valid time in any given scenario, and in our error message, we specify that we require HH:mm as a valid format, but 24 is an invalid hour, and thus is not a valid format. Documentation for HH:mm can be found in Java Docs under Patterns for Formatting and Parsing:

telegram-cloud-photo-size-5-6253642614461021448-y.jpg

https://docs.oracle.com/javase/8/docs/api/java/time/format/DateTimeFormatter.html

In addition, the screenshot below shows that we do not need to add in "nitty-gritty" details to the UG:

image.png

In this case, we decided to omit the detail that the 24th hour is in fact, invalid

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: As you mentioned in your reply: "we require HH:mm as a valid format, but 24 is an invalid hour". Exactly, it is an invalid hour, not format. Furthermore I would not claim it as a "nitty-gritty" detail, since it is a wrong error. Perhaps asking to the group to tell the user that their "hour" is wrong would be a "nitty-gritty" request, but an invalid time would be a reasonable expectation.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I think that very low severity only constitutes bugs that are purely cosmetic but still give clear understanding. However, this gives an incorrect error message that gives incorrect understanding, hence should not be very low severity.