search

pzmosquito / eslint-import-resolver-vite

Vite module resolution plugin for eslint-plugin-import.
MIT License
16 stars 4 forks source link

Add Typescript Vite Config Example #6

Closed tscritch closed 1 year ago

tscritch commented 1 year ago

Just ran into this problem and it wasted a lot of time. Hopefully this helps others save some time!

pzmosquito commented 1 year ago

Thank you for contributing the PR. Instead of adding a specific example for TypeScript, it's better to add information about vite.config.js being the default value, anything else needs to be specified in the configPath, e.g. configPath: "vite.config.ts".

Let me know if this solves your concern.

tscritch commented 1 year ago

Thanks for the quick reply @pzmosquito! I'm not sure I'm understanding. It would be nice to make it very obvious that the default value does not support the typescript version of the vite config file and the user needs to then specify the path. Maybe you are saying the same thing but could you provide a more clear example of what you'd like to see and I can fix up this PR. Thanks!

pzmosquito commented 1 year ago

updated README file with more description (f2d5719ed17754d712778398b96f60e8ae830680)