No app should install anything to root

pzorin / qgo

qGo is a Go Client (IGS, WING, LGS, WBaduk/CyberORO, Tygem, Tom, and eWeiqi) based on Qt 5. No active development is happening nor should any be expected.

GNU General Public License v2.0

82 stars 34 forks source link

No app should install anything to root #41

Open danielb2 opened 9 years ago

danielb2 commented 9 years ago

/boardtextures/ and /sounds/ is violating this. Any reason to do this?

pzorin commented 9 years ago

Works for me on Ubuntu 14.10. On which platform do you see this behaviour?

danielb2 commented 9 years ago

OSX installed it to root

pzorin commented 9 years ago

I suspected that, the variables QGO_INSTALL_PATH and QGO_INSTALL_BIN_PATH in qgo/src.pro are not set for mac os x. You can try setting them to whatever is appropriate. I can't be of much help since I do not use mac os and don't know its conventions.

danielb2 commented 9 years ago

Follows the same conventions as FreeBSD and most UNIX. It should be installed in /usr/local

Does that help?

pzorin commented 9 years ago

You can try replacing unix:!macx- { in src.pro by macx-* { Then everything will be installed to /usr/share. It seems however that qt applications are supposed to be deployed as something called "bundles" on mac os, and I am not really interested in learning how that works.

danielb2 commented 9 years ago

When the app is compiled, the result is qgo.app. It appears to be the whole self-contained app already. I deleted the other folders which had no noticeable impact, but I couldn't connect to a server and play so I couldn't tell for sure. Regardless, this is probably the "bundle" it's referring to.