search

pzs / nav-online-invoice

PHP interface for Online Invoice Data Reporting System of Hungarian Tax Office (NAV)
MIT License
147 stars 53 forks source link

Improvement testing #27

Closed davidsarkany closed 4 years ago

davidsarkany commented 4 years ago

I made some small improvements in the testing. The tests run on all PHP versions from PHP 5.4 to PHP 7.4.

pzs commented 4 years ago

Thanks for the PR, it's a great idea to run tests on all PHP versions. However it seems it's not enough to set the PHP_VERSION env variable to set the php version, please see this test run: https://github.com/pzs/nav-online-invoice/runs/1181557089?check_suite_focus=true (I replaced the phpunit with php -v) Under PHP 5.4 section:

Run php -v
PHP 7.4.10 (cli) (built: Sep  9 2020 06:36:14) ( NTS )

Probably action like https://github.com/marketplace/actions/setup-php-action has to be used to set the php version.