search

pzuraq / ember-simple-set-helper

MIT License
12 stars 4 forks source link

Fixes argument usage in AST transform #5

Closed patocallaghan closed 4 years ago

patocallaghan commented 4 years ago

This is a reproduction of the bug outlined in https://github.com/emberjs/ember.js/issues/18779

You can run the failing test by running: yarn test -s -f='it works without a value on an object'. I have also reproduced the issue on dummy app homepage.

Apologies but just to make sure I was accurately reproducing the issue in my app I upgraded the addon using ember-cli-update and fixed up some linting.

You can find the actual reproduction in https://github.com/pzuraq/ember-simple-set-helper/commit/80da59e86c6fad1cb8e3078e00ceb22a9de3d5de

pzuraq commented 4 years ago

CI isn't kicking off, but a run did pass: https://travis-ci.org/pzuraq/ember-simple-set-helper/builds/656307399

voltidev commented 4 years ago

I guess it fixes https://github.com/pzuraq/ember-simple-set-helper/issues/6?