Don't try to do stuff after transition if the component is destroying or destroyed

pzuraq / liquid-wormhole

Animated wormholes, built on Liquid Fire! Inspired by ember-wormhole

MIT License

20 stars 20 forks source link

Don't try to do stuff after transition if the component is destroying or destroyed #38

Closed alexspeller closed 7 years ago

alexspeller commented 7 years ago

Fixes #34

pzuraq commented 7 years ago

Thanks for the fix! 😄

Failure looks like it's only on beta, likely unrelated to this change. Going to merge and open up a separate issue for that.

pzuraq commented 7 years ago

Patch version published

billdami commented 7 years ago

@alexspeller @pzuraq any chance you can cut a new release with this fix? I'm seeing the same errors as #34 in my integration tests for components that extend ember-modal-dialog

pzuraq commented 7 years ago

This was released in v2.0.6, can you conifrm the version of liquid-wormhole?

billdami commented 7 years ago

@pzuraq ah my mistake! I was looking at https://github.com/pzuraq/liquid-wormhole/releases and for some reason it lists 2.0.5 as the latest release (which is what I was on). But the npmjs.com package page does correctly list the latest version :)