search

q-m / scrapyd-k8s

Scrapyd on container infrastructure
MIT License
12 stars 7 forks source link

Add nodename to response #27

Closed vlerkin closed 6 months ago

wvengen commented 7 months ago

After a CI rerun also the Kubernetes test is fine again :sweat_smile:

vlerkin commented 6 months ago

Thanks! It's good to always review your own PR. Doing a review of all changes, shows me that there are still unrelated whitespace changes with meaning (e.g. the newlines in the tests do convey something about the grouping - e.g. a comment of a missing test does not belong to the following method, so you can't just remove the empty newline. Linters and autoformatters don't have the final word!)

Could you still review and change this? When the whitespace is correct, the PR can be merged.

I deleted whitespace added by code formatter, if you notice there is still some whitespace that you think should be different - let me know. I am now having my Mac wiped out so I won't be able to access it for some time.