Closed lazyoracle closed 2 years ago
This pull request fixes 2 alerts when merging 0370d011fd4bb1948203a1160847bffd38a04f91 into af38dae1e85d6016783467c3167f145034f9ff78 - view on LGTM.com
fixed alerts:
When we talk next time, please explain this to me.
On Wed, 29 Dec 2021, 5:03 Anurag Saha Roy, @.***> wrote:
What
Physics simulation for Qiskit circuits Why
Simulating qiskit circuits by solving full physical dynamics of the system model (incl of classical electronics and imperfections) provies an easy interface to the rich simulator of c3-toolset How
Use the (now no longer) new methods for evaluating qasm representation of sequences Remarks
Add notes on possible known quirks/drawbacks of this solution. If this introduces an API-breaking change, please provide an explanation on why it is necessary to break API compatibility and how users should update their notebook/script workflows once this PR is merged. Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines https://github.com/q-optimize/c3/blob/dev/CONTRIBUTING.md for more details. You can mark an item as complete with the - [x] prefix
- Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
- Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
- Type Annotations - All new code has been type annotated in the function signatures using type hints
- Docstrings - Docstrings have been provided for functions in the numpydoc style
- Documentation - The tutorial style documentation has been updated to explain changes & new features
- Notebooks - Example notebooks have been updated to incorporate changes and new features
- Changelog - A short note on this PR has been added to the Upcoming Release section
You can view, comment on, or merge this pull request online at:
https://github.com/q-optimize/c3/pull/165 Commit Summary
- 7744aca https://github.com/q-optimize/c3/pull/165/commits/7744acacfe312d93287c1fc16a76fe6a70cc4ddf use name field like single qubit gates
- 286edcc https://github.com/q-optimize/c3/pull/165/commits/286edcc604c5910621a702bae19cc2f32ee66bfa ensure device has enough qubits for circuit
- 86b2b5d https://github.com/q-optimize/c3/pull/165/commits/86b2b5d1c4ff67e01e3aad25f8d04e744ab9b211 ad-hoc hardcoded basis gates
- e9eecd5 https://github.com/q-optimize/c3/pull/165/commits/e9eecd523ea4ad86e341fe812c3e51089e2a26a8 create c3 experiment object and compute propagators
- 52eb787 https://github.com/q-optimize/c3/pull/165/commits/52eb78706bdd7558bd64a20f05cdbbc64eccc6df convert and evaluate instructions in qasm style
- f21f7c3 https://github.com/q-optimize/c3/pull/165/commits/f21f7c331ce535a78b1a9fbb2e1da9e6a137f340 remove redundant conversion to c3 legacy style instructions
- 4309f67 https://github.com/q-optimize/c3/pull/165/commits/4309f67b861c2fe11b6ebf663355731bc4cbfe1b bump versions and remove mypy dependencies
- 7ebfeac https://github.com/q-optimize/c3/pull/165/commits/7ebfeacd97662b6069cd3de7e64f964eed863ce2 config file for qiskit physics simulations
- 0ce0dd9 https://github.com/q-optimize/c3/pull/165/commits/0ce0dd966e49a55876f07a52d3fd09e6f6705708 basic test for qiskit physics simulation
- a83f47b https://github.com/q-optimize/c3/pull/165/commits/a83f47b1d060e21809a4d6e71aba2157918e7212 process circuit and obtain output probabilities
- 6b9d1b6 https://github.com/q-optimize/c3/pull/165/commits/6b9d1b6485050e44cdd77b126c1fbd64e5f79a22 cleanup TODOs and leftovers
- d31b750 https://github.com/q-optimize/c3/pull/165/commits/d31b7506515b077d75ab2de93d4711bbd50e339c show circuit output for debugging
- f11aef6 https://github.com/q-optimize/c3/pull/165/commits/f11aef6b7520cae762d14de649ce69c3e9ec3fe9 ignore mypy warning in pwc
- 0370d01 https://github.com/q-optimize/c3/pull/165/commits/0370d011fd4bb1948203a1160847bffd38a04f91 create a local circuit for testing
File Changes
(6 files https://github.com/q-optimize/c3/pull/165/files)
- M .pre-commit-config.yaml https://github.com/q-optimize/c3/pull/165/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9 (14)
- M c3/experiment.py https://github.com/q-optimize/c3/pull/165/files#diff-beef00f09cb4cffa20b28ab61f6f0233e2fdc09f263d5bb033947c6afe864d77 (2)
- M c3/libraries/propagation.py https://github.com/q-optimize/c3/pull/165/files#diff-1b931076821f8cb9809c2d79c339bb9dc5dbd606993405e2c346f8388404e3d6 (4)
- M c3/qiskit/c3_backend.py https://github.com/q-optimize/c3/pull/165/files#diff-7a9f4483ed1359fe5e81e06dba7130e90b71c9a33a35a44c9f513c7157b0aa14 (36)
- A test/qiskit.cfg https://github.com/q-optimize/c3/pull/165/files#diff-d9784c67864ede4df0a65c7e6a601e643ebeef3373ce820b790d44bc8773d53a (29)
- M test/test_qiskit.py https://github.com/q-optimize/c3/pull/165/files#diff-af951b133417b900925a33f3be5221547017b3904bfe26253a46249bb7f63688 (13)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/q-optimize/c3/pull/165, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH3Q4IAOROZC3NTSKG4F3LUTJ3ANANCNFSM5K5FFLLQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Merging #165 (eac7c24) into dev (af38dae) will increase coverage by
0.40%
. The diff coverage is91.66%
.
@@ Coverage Diff @@
## dev #165 +/- ##
==========================================
+ Coverage 71.81% 72.22% +0.40%
==========================================
Files 36 36
Lines 5475 5476 +1
==========================================
+ Hits 3932 3955 +23
+ Misses 1543 1521 -22
Impacted Files | Coverage Δ | |
---|---|---|
c3/experiment.py | 78.41% <ø> (+0.35%) |
:arrow_up: |
c3/libraries/propagation.py | 57.09% <0.00%> (ø) |
|
c3/qiskit/c3_backend.py | 89.78% <100.00%> (+10.86%) |
:arrow_up: |
c3/qiskit/c3_backend_utils.py | 60.71% <0.00%> (+1.78%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update af38dae...eac7c24. Read the comment docs.
This pull request fixes 2 alerts when merging 1ca37326106a3d07f8f52b64051688e662fe2e79 into af38dae1e85d6016783467c3167f145034f9ff78 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging d5da67f751aefff503947bd310bb92665525a390 into af38dae1e85d6016783467c3167f145034f9ff78 - view on LGTM.com
fixed alerts:
This pull request fixes 2 alerts when merging eac7c243ad8d6c4b8c5c36889116d0c0e86e61f4 into af38dae1e85d6016783467c3167f145034f9ff78 - view on LGTM.com
fixed alerts:
What
Physics simulation for Qiskit circuits
Why
Simulating qiskit circuits by solving full physical dynamics of the system model (incl of classical electronics and imperfections) provies an easy interface to the rich simulator of
c3-toolset
How
Use the (now no longer) new methods for evaluating qasm representation of sequences
Remarks
Pending TODOs
Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the
- [x]
prefixblack
andflake8
have been used to ensure styling guidelines are metnumpydoc
style