Closed YonatanGideoni closed 2 years ago
Merging #230 (fd79d3b) into dev (01cd657) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #230 +/- ##
==========================================
+ Coverage 74.82% 74.85% +0.02%
==========================================
Files 38 38
Lines 5534 5535 +1
==========================================
+ Hits 4141 4143 +2
+ Misses 1393 1392 -1
Impacted Files | Coverage Δ | |
---|---|---|
c3/signal/gates.py | 95.60% <100.00%> (+0.57%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Review was dismissed by Github because of conflict resolution, nothing important changed.
@YonatanGideoni Setup the pre-commit
hooks as described in the CONTRIBUTING document so that all commits are blacked and linted by default.
What
Makes the
Instruction
class properly assign ideal gate inside constructor. Also fixes thetwo_qubits_entangling_gate.ipynb
example notebook.Why
Closes #229
How
Added
self.set_ideal(ideal)
toInstructions
constructor.Remarks
None
Checklist
Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the
- [x]
prefixblack
has been used to ensure styling guidelines are metnumpydoc
style