q-optimize / c3

Toolset for control, calibration and characterization of physical systems
https://c3-toolset.readthedocs.io/
Apache License 2.0
66 stars 36 forks source link

Wrong sign in xy_angle in phase in Instruction class #231

Closed YonatanGideoni closed 2 years ago

YonatanGideoni commented 2 years ago

Describe the bug

Currently the xy_angle has the wrong sign in the class so rotations on the Bloch sphere are done in the wrong direction.

To Reproduce

Please see the following Jupyter notebook: https://drive.google.com/file/d/1Rr5UnSySztis5ZGiY-0v6fvJ94VA8XYd/view?usp=sharing

Expected behavior

For example, for the ry90 gate to do the transition image instead of image as it currently does.

Screenshots

image Small difference is because of the unoptimised pulse.

Environment (please complete the following information)

Additional context

Solution - remove the minus sign.