q231950 / the-stubborn-network

A Swifty and clean stubbing machine.
MIT License
7 stars 3 forks source link

Move log into into a earlier stage in the PersistenceStubSource #56

Closed osrufung closed 3 years ago

osrufung commented 3 years ago

When one of the stubs doesn't match (because one of the options has changed) we are not aware of this because the print sentence is done only when the source contains the stub (when it maches), so... we need to move these verbose info into a earlier stage.

sourcelevel-bot[bot] commented 3 years ago

SourceLevel has finished reviewing this Pull Request and has found:

See more details about this review.

osrufung commented 3 years ago

@q231950 silly fix :)

q231950 commented 3 years ago

Thanks @osrufung , looks good! ~Could you please remove the one empty space that source level is talking about? Sorry for the pickiness, just want to make the linter happy~ doesn't seem to be related to your changes 😊

q231950 commented 3 years ago

Actually it was there 🤷🏻‍♂️ Anyways, it's gone now

Screenshot 2021-07-06 at 20 41 14
osrufung commented 3 years ago

@q231950 oh, those mysterious whitespaces 😉 thank you Kim!