search

q9f / eth.rb

a straightforward library to build, sign, and broadcast ethereum transactions anywhere you can run ruby.
https://q9f.github.io/eth.rb
Apache License 2.0
204 stars 88 forks source link

eth/abi: support dynamic array encoding #122

Closed peter-chung-xfers closed 2 years ago

peter-chung-xfers commented 2 years ago
q9f commented 2 years ago

Thank you! Could you run rufo and remove the stray pp?

codecov-commenter commented 2 years ago

Codecov Report

Merging #122 (cabebbb) into main (bb640c7) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          67       67           
  Lines        3855     3899   +44     
=======================================
+ Hits         3845     3889   +44     
  Misses         10       10
Impacted Files Coverage Δ
lib/eth/abi.rb 100.00% <100.00%> (ø)
lib/eth/contract/function.rb 100.00% <100.00%> (ø)
lib/eth/contract/function_input.rb 100.00% <100.00%> (ø)
spec/eth/abi_spec.rb 100.00% <100.00%> (ø)
lib/eth/client.rb 100.00% <0.00%> (ø)
spec/eth/client_spec.rb 100.00% <0.00%> (ø)
spec/eth/signature_spec.rb 100.00% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

q9f commented 2 years ago

Thank you, can you fix the tests?

peter-chung-xfers commented 2 years ago

Thank you, can you fix the tests?

fixed

peter-chung-xfers commented 2 years ago

Hey @q9f just wondering if you have found any viable testsuite for this?

q9f commented 2 years ago

No, but there is an open ticket here: https://github.com/ethereum/tests/issues/691