search

q9f / eth.rb

a straightforward library to build, sign, and broadcast ethereum transactions anywhere you can run ruby.
https://q9f.github.io/eth.rb
Apache License 2.0
204 stars 88 forks source link

Add gas limit override option for contract deployments #128

Closed dansimpson closed 2 years ago

dansimpson commented 2 years ago

I've had some deployment failures due to running out of gas on deployment when a constructor is invoked. In some cases the intrinsic gas limit is off by a factor of 10. This change allows the developer to override the calculated model if necessary, without breaking the API.

codecov-commenter commented 2 years ago

Codecov Report

Merging #128 (8f236ef) into main (19e7c20) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          67       67           
  Lines        3855     3874   +19     
=======================================
+ Hits         3845     3864   +19     
  Misses         10       10
Impacted Files Coverage Δ
lib/eth/client.rb 100.00% <100.00%> (ø)
spec/eth/client_spec.rb 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more