search

q9f / eth.rb

a straightforward library to build, sign, and broadcast ethereum transactions anywhere you can run ruby.
https://q9f.github.io/eth.rb
Apache License 2.0
204 stars 88 forks source link

Rename `Eth::Client::Http/HttpAuth/Ipc#send` method to `send_request`? #171

Closed d4mk0 closed 1 year ago

d4mk0 commented 1 year ago

Sometimes I try call send method directly i.e. now, I send eth_client.send(:call_payload, ...) to get encoded value for next step. And @q9f what do you think about it? Can I rewrite Eth::Client::_child_#send methods to something like send_request? We also can use object.__send__ method right now, but it's not obvious

q9f commented 1 year ago

I've had issues with the design of how we implement send so I would not be opposed to such a change if you want to give this a try.

edit: yes!