Closed a-moreira closed 1 year ago
Merging #173 (38c3f14) into main (85e2283) will decrease coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #173 +/- ##
==========================================
- Coverage 99.75% 99.70% -0.05%
==========================================
Files 70 70
Lines 4016 4061 +45
==========================================
+ Hits 4006 4049 +43
- Misses 10 12 +2
Impacted Files | Coverage Δ | |
---|---|---|
lib/eth/client.rb | 98.69% <100.00%> (-1.31%) |
:arrow_down: |
spec/eth/client_spec.rb | 100.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
hey @kurotaky, the build in Ubuntu is failing because it lacks libyaml
I guess, but idk why this error started now :thinking:
Thanks, I'll fix the CI.
Adding a method to check if transaction has succeeded. Also took the opportunity to change the name of
is_mined_tx?
->tx_mined?
to be closer to Ruby conventions (boolean methods with?
withoutis_
)