search

q9f / eth.rb

a straightforward library to build, sign, and broadcast ethereum transactions anywhere you can run ruby.
https://q9f.github.io/eth.rb
Apache License 2.0
200 stars 86 forks source link

Not only ethereum net supporting (Gas Limit validation problem) #226

Open d4mk0 opened 1 year ago

d4mk0 commented 1 year ago

Hi! 👋 Sometimes I use this lib to interact with different L2 networks. I.e. optimism, arbitrum

I found few issues, but now I see only one. I dont know how we can except this problem, but it is problem, and 🐒 (monkeypatching) only now can fix it.

Im about problem with tx gas limit validation. Now https://github.com/q9f/eth.rb/blob/main/lib/eth/tx.rb#L206 we can only set 30kk limit, but sometimes in L2 we should set it higher.

I think it can be good first issue for some person. Also we can discuss it in https://t.me/ruby_eth (about EVM like chains)

TY for u attention!

q9f commented 1 year ago

Maybe a good thing would be to create a configuration for eth.rb that can be used and adjusted as we go.

Indeed, a good first issue :)

MujahidAli954 commented 1 year ago

I want to work on this can you assign this to me

q9f commented 1 year ago

Sure, let me know if you need anything!