search

qAIRa / qAIRaMap-OpenSource

Website for air quality monitoring
https://qairamap-test-opensource.qairadrones.com
GNU General Public License v2.0
4 stars 23 forks source link

Fix "similar-code" issue in src/lib/mobileAssets.js #111

Open SabCampos opened 2 years ago

SabCampos commented 2 years ago

Similar blocks of code found in 2 locations. Consider refactoring.

https://codeclimate.com/github/qAIRa/qAIRaMap-OpenSource/src/lib/mobileAssets.js#issue_614a83ca108838000100005a

shyung18 commented 2 years ago

I'll like to try this out!

SabCampos commented 2 years ago

Great! Thanks!

shyung18 commented 2 years ago

It looks like there are two "similar-code" issues in src/lib/mobileAssets.js. Which one is this issue? Is this the function selectMobileTrip or data.reduce?

developer22-university commented 2 years ago

@shyung18 I would suggest you to understand both the functions , work in your environment and decide which one should be refactored. Did u find ?

shyung18 commented 2 years ago

It's just that issue 112 deals with the other 'similar-code' issue so I just want to make sure I am dealing with the right problem in this issue.