qLab / qLib

A procedural asset library for SideFX Houdini. https://www.facebook.com/qLibHoudini

http://qlab.github.io/qLib

Other

744 stars 116 forks source link

Switch open_dir to webbrowser to fix it on Windows #1296

Closed ababak closed 2 months ago

ababak commented 3 years ago

It doesn't work on Windows now. By switching to webbrowser.open it should work on all platforms.

ababak commented 3 years ago

1273

ababak commented 2 years ago

This is a cross-platform solution, there should be no regression for other platforms but it will fix the Windows issue. Please review.

johnnyquest commented 2 months ago

@ababak apologies on the long delay for this one. I'm hoping to fix the opendir() for windows soon, but I'm not going to use webbrowser.open because that, well, opens the web browser on my computer if I try to use it ¯_(ツ)/¯

ababak commented 2 months ago

@johnnyquest it opens the webbrowser only when the link is not accessible or not formatted well

johnnyquest commented 2 months ago

@ababak on my linux box it opens the web browser, no matter what (and I'm not particularly surprised tbh :shrug: ) could you please try the latest version (0.2.257) though, that should work on windows now as well -- please let me know whether it does