qMRLab / mooc

MyST book
http://qmrlab.org/mooc/
MIT License
0 stars 0 forks source link

Proposal: diverging colormaps for B0 chapter #14

Open mathieuboudreau opened 1 month ago

mathieuboudreau commented 1 month ago

Following up on #12, I'm suggesting to switch the B0 maps from grayscale to a diverging colormap (I have a preference of blue-white-red since it's intuitive), with white set to 0, blue negatives, red positives. I'm open to a discussion, how are they being displayed in Shimming-Toolbox?

Here's what they look like with my changes,

Figure 5.1

5-1-1

Figure 5.3

5-1-3-1

5-1-3-2

Figure 5.9

5-2-4

mathieuboudreau commented 1 month ago

It all looks great to me, thanks!

Before merging, wanted to give you heads up that the deploy workflow on main sets mb/dev as trigger ref

https://github.com/qMRLab/mooc/blob/f40f0c15caf44d803c26f6b52f82d574779cb03e/.github/workflows/deploy.yml#L5

Yep thanks! I was about to change it to main again last night but fell asleep haha - will do asap

mathieuboudreau commented 1 month ago

Thanks all! I was about to merge when I noticed the colors are going the wrong way (blue should be negative and red positive) - I think plotly has two different definitions for this diverging colormap - I'll look up the other one and fix it prior to merge!

po09i commented 1 month ago

the colors are going the wrong way

Good catch!