qTox crashed when pasting large text

[zetok]

32c33024623444e327346cd779ecbff8e447003a

https://gist.github.com/zetok/7c98eb040eae5451001d

I've tried to send test sample of text to ToxBot, qTox didn't like it.

[zetok]

Reproducible on cb812005824f3bd8222ecebd156421b78c3f00fd

[dubslow]

I would bet this is related to tab completion. Can you test https://github.com/tux3/qTox/commit/cd59117fa940d851c244b2f259abbe5c0888535c? If you can't reproduce there but can reproduce on https://github.com/tux3/qTox/commit/b6d581a462880ce7fe4919f3008fee5da14442a5, then it's definitely tab completion problem (specifically, with how KeyPressEvents are intercepted from the chat input).

[zetok]

@dubslow same result on cd59117fa940d851c244b2f259abbe5c0888535c

[dubslow]

Shit really?

What message are you sending?

@apprb

[zetok]

@dubslow test sample I've used, copied into qTox using leafpad: http://a.pomf.se/fffboi.7z

[tux3]

Does it still happen if you just paste the text into qTox but don't send the message ?

What if you wait a couple of minute between copypasting and sending ?

[zetok]

@tux3 still aborts when pasting without sending, though something interesting, when gdb catches abort:

[apprb]

Tried yesterday to send whole text: 1) Just pasting is OK, but you have to wait some time (probably GenericChatForm::msgEdit->setUndoRedoEnabled(false); may be usefull). 2) Sending: I got bored to wait.

[dubslow]

Fixed?

[zetok]

@dubslow can't really verify, since when I've pasted text RAM usage in matter of seconds increased to >1.4GB before I've pressed ^C in gdb.

EDIT: oh, I guess it's probably "fixed", since it no longer has SIGABRT when trying to use >512MB of RAM when pasting text…

[tux3]

Welp.