search

qTranslate-Team / woocommerce-qtranslate-x

Enables multilingual framework for plugin "WooCommerce - excelling eCommerce".
GNU General Public License v3.0
11 stars 19 forks source link

Fixes for categories, tags and product attributes #1

Closed mweimerskirch closed 9 years ago

mweimerskirch commented 9 years ago

more to come

This might also help with https://github.com/qTranslate-Team/qtranslate-x/issues/25#issuecomment-75733872 but I wasn't able to reproduce the missing translations in that place.

wocmultimedia commented 9 years ago

Hello John, Here's again my test about. You can understand from the shot enclosed. The former attribute created with qTranslate-support for woocommerce in frontend are still not shown correctly since latest version of qTranslate-x and woocommerce-qx plugin. (see the Format in the shot) While, if I create a new attribute item it's correctly shown (see Lingua - Tedesco). I wish it can help you understand the problem. It happen only with the attribute's items and not with attribute. Everything works fine but not the attribute's items frontendvisualizationproblem

johnclause commented 9 years ago

Hi Michel, I pulled it in, so that we have a copy of it in the code, but it did not help me in all my testing and I commented it out. All works fine without it. Angelo's problem was solved by re-saving the attributes.

However, custom attributes indeed do not work, but they do not work even without -X, as far as I could see. Their code with custom attributes seems to be very strange and I do not see how it can reliably work. They create slug on each custom attribute, then compare sanitized attribute name to attribute slug to find the choices. If name was changed, it stops matching. When you delete attribute, slug stays. It is a mess ...

I am not sure how important it is. Do you use custom attributes on any of your sites?

I also listed you as an author. I do not think you have to deprecate your plugin now, since there is still a lot of folks running old qTranslate and mqTranslate, for whom your plugin is the only choice, but you may wish to make a note in the description to use this plugin for -X.

The latest version from github has some additional improvements on visualization of attributes, you will see it in the code. Could you please test it before I release?

If you think we need to fix custom attributes, I will need a reproducible way to see how it works without -X, and then how it does not work with -X, or submit another PR if you find a way to make it reliably work with and without -X.

Last question, would you be able to scan and answer support threads on this plugin? If you promise to do so, I will enable you for commit rights ;) We will have to discuss and make rules how we will coordinate on joined support and development, write me to qtranslateteam a t gm a il d com.