search

qTranslate-Team / woocommerce-qtranslate-x

Enables multilingual framework for plugin "WooCommerce - excelling eCommerce".
GNU General Public License v3.0
11 stars 19 forks source link

Fix for the "note added to your order" mail (+ possibly others sent over ajax) #10

Closed mweimerskirch closed 9 years ago

mweimerskirch commented 9 years ago

Append the language to ajax links on the order edit page, so that mails are sent in the language the customer used during the order process

Needed, so the "note added to your order" mails are sent in the correct language Issue #3

johnclause commented 9 years ago

I am a bit confused, why would we add another function on the same filter? Cannot we do all in one function? I can merge it in one if you do not mind?

mweimerskirch commented 9 years ago

I see a few reasons as to why not to combine them. Keeping them separate increases readability because the functions stay more modular. Also, both of these filters are more like "worarounds" than really clean solutions, so If one of the needs to be replaced for a future WooCommerce update, it's "tidyer" if there are separate functions. A third reason is that you can disable them individually for testing purposes by just commenting out the corresponding "add_filter" line. You can of course merge them if you don't agree. This might just be my personal opinion.

johnclause commented 9 years ago

Yes, that all makes sense, thanks.