search

qa-dev / jsonwire-grid

High-performance scalable implementation of Selenium Grid
MIT License
74 stars 10 forks source link

server.Shutdown return err #13

Closed ghost closed 7 years ago

ghost commented 7 years ago

Check function Shutdown.

podtserkovskiy commented 7 years ago

Hi! What's wrong with it? ~na locale rabotayet~

INFO[0000] /home/gopath/src/github.com/qa-dev/jsonwire-grid/config-local-sample.json 
INFO[0000] Set log level to: debug                      
INFO[0000] Create statsd client to :0 via  with prefix "", muted is true. 
INFO[0000] Statsd client was created.                   
INFO[0003] Shutting down the server...                  
INFO[0003] Server gracefully stopped
podtserkovskiy commented 7 years ago

This is the expected behavior https://github.com/golang/go/blob/47c868dc1c92fcd75ca1574cc5a5fae4797e2271/src/net/http/server.go#L2705

// Serve always returns a non-nil error. After Shutdown or Close, the // returned error is ErrServerClosed. func (srv *Server) Serve(l net.Listener) error {