qa-tools / behat-extension

Behat extension for integration with QA-Tools
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

Composer.json adjustments #3

Closed aik099 closed 10 years ago

aik099 commented 10 years ago
  1. change package name (the name key) to: qa-tools/behat-extension
  2. remove dependency to Mink ("behat/mink": "dev-master",), because MinkExtension already has it
  3. change qa-tools dependency ("aik099/qa-tools": "dev-master") to *@dev, because it's valid version format and it will automatically pickup release when it happens, while dev-master is fixed link to master branch
  4. not sure about "minimum-stability": "dev",, maybe it's not needed at all and better to specify @dev in required package version in project's own composer.json
  5. remove the repositories key, because qa-tools library is already published on packagist
  6. split autoload into autoload (for main code) and autoload-dev (for tests)
  7. fixed mixed use of tabs/spaces
  8. change dependency from aik099/qa-tools to qa-tools\qa-tools
evangelion1204 commented 10 years ago

The "minimum-stability": "dev", seems to be needed for some dependencies of qa-tools\qa-tools, there are even more:

a-tools/qa-tools 1.0.x-dev requires mindplay/annotations dev-master -> no matching package found.
    - qa-tools/qa-tools dev-master requires mindplay/annotations dev-master -> no matching package found.

Maybe I should keep it or we need to fix it there or you already know what the problem is

aik099 commented 10 years ago

That's the Composer's trick. If it happens, that you rely on non-released version (in dev-master) or used dependencies, then you need to include them in your project's composer.json. That's why on QA-Tools installation instructions you not only need to include qa-tools/qa-tools but also mindplay/annotations, since otherwise you'll get same exception.

I bet you need to manually list dev versions of mink & drivers in project's composer.json or otherwise 1.5 versions will be used.

evangelion1204 commented 10 years ago

I think we can close it, was done with #8.

aik099 commented 10 years ago

Closing via 2e651b5958cf609984d654581a574521e965a4f1