Puppets permanently connected after user leaves Discord server

qaisjp / go-discord-irc

The Discord and IRC bridge with puppets! An IRC user is created for each Discord user, messages from IRC seamlessly appear on Discord, and Discord mentions are automagically converted to and from IRC.

MIT License

113 stars 32 forks source link

Puppets permanently connected after user leaves Discord server #45

Closed Kirtaner closed 4 years ago

Kirtaner commented 5 years ago

Currently only restarting the bridge will remove IRC connections that are no longer valid.

However, this might be better as a configurable setting as large Discord servers would subject the IRC channels with elevated amounts of join/part spam.

qaisjp commented 5 years ago

Yeah, we can probably just make them quit with reason "Left Discord server". With a setting to instead just translate that into a "going offline" message, so it will quit after the regularly defined number of hours

bluddy commented 4 years ago

Seems like a pretty serious bug. Any intention of fixing this?

(I'm considering moving from matterbridge to this far superior implementation, at least until matterbridge catches up)

qaisjp commented 4 years ago

Yes, it's a pretty easy fix, I just need to get round to doing it! Let me see...

qaisjp commented 4 years ago

Alright, now the irc connection immediately leaves the server when the Discord user does.

This doesn't include the suggestion of reducing join/quit spam. If someone needs it, I can add it.