search

qaisjp / go-discord-irc

The Discord and IRC bridge with puppets! An IRC user is created for each Discord user, messages from IRC seamlessly appear on Discord, and Discord mentions are automagically converted to and from IRC.
MIT License
113 stars 32 forks source link

missing irc_server_name #98

Closed BCC-BGChatCommunity closed 3 years ago

BCC-BGChatCommunity commented 3 years ago

FATA[0000] 'irc_server_name' config option is required and cannot be empty

llmII commented 3 years ago

Looks as if that was a severe oversight in my case in #75 to not have at least included a commented out version in config.yml when I submitted the PR. Sorry about that. I'd also note that (unless I'm remembering incorrectly) the discriminator (what irc_server_name sets) is case sensitive. No idea if it should/shouldn't be but I tend to prefer things be case sensitive. That said I'd think the default irc_server_name should be lower case (tapping an extra CAPS LOCK or holding SHIFT where one has purposefully disabled CAPS LOCK on their keyboard wouldn't be very fun just to get a message out to a user by default I'd guess).

qaisjp commented 3 years ago

thank you!