Usage of HttpKernelInterface::MAIN_REQUEST makes 5.3 the lowest compatible version

qandidate-labs / stack-request-id

Middleware for adding a request id to your Symfony Requests

MIT License

48 stars 14 forks source link

Usage of HttpKernelInterface::MAIN_REQUEST makes 5.3 the lowest compatible version #41

Closed wjzijderveld closed 3 years ago

wjzijderveld commented 3 years ago

The added typehints also made <5.0 already non-compatible.

othillo commented 3 years ago

Should we revert the MAIN_REQUEST to allow Symfony >= 5.0 ?

wjzijderveld commented 3 years ago

Might be nice yeah, I think that would also allow this version to be used with http-foundation ^4.4 again, which might be nice for some. I'll add the change

wjzijderveld commented 3 years ago

After checking again, we need at least 5.1.5 because of a security issue. That would already exclude http-foundation ^4.4 as well, so I'm not sure it's actually worth reverting this. If people can use http-kernel ^5.1.5 they most likely also can use ^5.3?