qanuj / elmah

Automatically exported from code.google.com/p/elmah
0 stars 0 forks source link

Incorrect ErrorId (type) and Message in MySqlErrorLog (RB-1.2) #153

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Two bugs:

1) MySqlErrorLog.cs line 283 - this is setting up the Message parameter but
the source variable is used to determine the string length

2) MySql.sql line 48 - The elmah_error.ErrorId column is crated as char(36)
but it is used as a binary field in the code. The easiest fix is to make
the field binary(16), but if the intention is to use the GUID ids as
strings, the field can be left char(36) and the code changed. The attached
patch changes the field to binary(16).

Original issue reported on code.google.com by paul.wid...@gmail.com on 24 Jan 2010 at 11:48

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 24 Jan 2010 at 11:51

GoogleCodeExporter commented 9 years ago

Original comment by azizatif on 24 Jan 2010 at 11:58

GoogleCodeExporter commented 9 years ago
Patch has been accepted.

Original comment by nberardi on 25 Jan 2010 at 12:33

GoogleCodeExporter commented 9 years ago
For x-reference purposes...patch applied in r704.

Original comment by azizatif on 25 Jan 2010 at 1:18