qaprosoft / qps-pipeline

Jenkins pipeline and jobdsl scripts
11 stars 15 forks source link

Update sonar functionallity to handle 7.9.3 version #833

Closed sandinosanchez closed 4 years ago

sandinosanchez commented 4 years ago

In 5.1 we are going to update sonarqube to 7.9.3 so all previous logic needs to be updated aswell. New functionallity to handle pr decorator and decompose old sonar class into the SonarCient to suport custom sonarqube instances.

sandinosanchez commented 4 years ago

Environment:

Objective:

Pre conditions:

Test scenario:

  1. Run registerOrganization job
  2. Run registerRepository job with carina-demo
  3. Create a branch from master in your froked carina-demo
  4. Modify a class with some unused fields(ping me for information about this one)
  5. Create a pr from that branch to master

Expected results

  1. onPush job executed successfully
  2. sonar scanner results should be displayed in the pr > checks tabs Screenshot from 2020-07-06 10-16-19
ghost commented 4 years ago

Verified on my env. Done.

Screen Shot 2020-07-06 at 10 29 51 PM
sandinosanchez commented 4 years ago

some improvements where made in #836 need to re test with previous test steps, same environment.

@okamara ping me if you need help with the configuration.

ghost commented 4 years ago

Reverified. Fixed.