qarmin / czkawka

Multi functional app to find duplicates, empty folders, similar images etc.
Other
18.36k stars 604 forks source link

Reference folder feature not working, I can still select files in the reference folder #1213

Open Mewto7 opened 4 months ago

Mewto7 commented 4 months ago

Bug Description I can still select files in the reference folder

Steps to reproduce: Files in the reference folder should not be selectable. 2024-02-19_182137

System

qarmin commented 4 months ago

When reference button was selected? Before or after scan? - items from reference folders should be visible on dark row, not in normal rows.

Mewto7 commented 4 months ago

When reference button was selected? Before or after scan? - items from reference folders should be visible on dark row, not in normal rows.

Hello there! Nice to meet you. Thanks for this awesome tool.

Reference was selected before the scan. Should I select it afterwards? Thanks again.

qarmin commented 4 months ago

No, this should work fine, when selecting button before scan. But such state as in screenshoot should be only visible when all folders are normal folders.

I think that this could be fixed already(not 100% sure, because other users reported this on Linux) - windows msys2 version not contains important bugfix so paths looks strange and could not work as expected

Mewto7 commented 4 months ago

No, this should work fine, when selecting button before scan. But such state as in screenshoot should be only visible when all folders are normal folders.

I think that this could be fixed already(not 100% sure, because other users reported this on Linux) - windows msys2 version not contains important bugfix so paths looks strange and could not work as expected

Looks like it is failing to determine if the reference button is set. I see that the new version is out. I will try to run that and report back.

I won't have used msys2 version but the release version isn't running for me. I made an issue here #1208

qarmin commented 4 months ago

There are many reported problems with gui gtk and for most of them I could write back very simply "it works for me". - I have no way of either verifying or fixing them, so that is why a new gui is being created, which should work a lot of better on Windows/Mac.

Can you check if the problem occurs on it? It is missing a lot of features, but these are the ones it should have

https://github.com/qarmin/czkawka/releases/tag/7.0.0 - windows_krokiet.exe or windows_krokiet_console.exe

Mewto7 commented 4 months ago

There are many reported problems with gui gtk and for most of them I could write back very simply "it works for me". - I have no way of either verifying or fixing them, so that is why a new gui is being created, which should work a lot of better on Windows/Mac.

Can you check if the problem occurs on it? It is missing a lot of features, but these are the ones it should have

https://github.com/qarmin/czkawka/releases/tag/7.0.0 - windows_krokiet.exe or windows_krokiet_console.exe

windows_krokiet.exe gets by Defender and doesn't run at all.

On windows_krokiet_console.exe

I get this:

2024-02-19_204409

Please let me know if I can help more. Thanks.

qarmin commented 4 months ago

Looks that computer have problem with graphics drivers/proper opengl handling and using software renderer should fix problem.

This is how I enable this on linux

SLINT_BACKEND=software krokiet

so probably windows will need to use this command(needs to be changed if not works)

set SLINT_BACKEND=software && start windows_krokiet_console.exe
Mewto7 commented 4 months ago

so probably windows will need to use this command(needs to be changed if not works)

set SLINT_BACKEND=software && start windows_krokiet_console.exe

I get this error: 2024-02-19_211206

Opening this in cmd seems to say something else with your command, but it disappears too fast for me to screenshot it.

qarmin commented 4 months ago

Setting this via gui is probably the easiest option for me on windows(probably this step require to restart os, but not sure)

variable => SLINT_BACKEND value => software

https://phoenixnap.com/kb/windows-set-environment-variable#ftoc-heading-4

Mewto7 commented 4 months ago

Setting this via gui is probably the easiest option for me on windows(probably this step require to restart os, but not sure)

variable => SLINT_BACKEND value => software

https://phoenixnap.com/kb/windows-set-environment-variable#ftoc-heading-4

2024-02-19_213517 Like this?

qarmin commented 4 months ago

Yes

Mewto7 commented 4 months ago

Yes

I did as you said. Restarted and the same output. I just checked the Open GL version of my MOBO. It says 2.1. Is that the issue? Note that the msys2 version worked fine for me. Can I do that somehow?

qarmin commented 4 months ago

msys2 gtk version is probably compiled with different flags that dll inside zip file.

Looks that msys version of Czkawka will be updated soon - https://github.com/msys2/MINGW-packages/pull/20109

I have no idea why the software renderer doesn't work - the opengl/femtovg/shaders message means that the regular version is still trying to run

When completed - https://github.com/qarmin/czkawka/actions/runs/7962237903 - at the bottom of page, should be created artifacts with krokiet with only software renderer, which should work.

if it doesn't work, I have no idea what could work

Mewto7 commented 4 months ago

msys2 gtk version is probably compiled with different flags that dll inside zip file.

Yes, I guess somehow, when using that, it sets itself correctly.

Looks that msys version of Czkawka will be updated soon - msys2/MINGW-packages#20109

That is such a relief. I love this software.

I have no idea why the software renderer doesn't work - the opengl/femtovg/shaders message means that the regular version is still trying to run

It could be that my PC is very old.

When completed - https://github.com/qarmin/czkawka/actions/runs/7962237903 - at the bottom of page, should be created artifacts with krokiet with only software renderer, which should work.

I will give that a try. I will keep updating this thread.

if it doesn't work, I have no idea what could work

Thanks for helping me out. By the way, defender is blocking the software. You might want to look into that.

qarmin commented 4 months ago

Binaries are unsigned so it is expected that defender and other antiviruses will show warnings, but for me the most important is that virustotal not shows any problems(except one unknown antivirus, which looks like false positive)

Mewto7 commented 4 months ago

When completed - https://github.com/qarmin/czkawka/actions/runs/7962237903 - at the bottom of page, should be created artifacts with krokiet with only software renderer, which should work.

Hey!!! I tried the last two and they work perfectly! The reference issue is gone too.

https://github.com/qarmin/czkawka/actions/runs/7962237903/artifacts/1257129444

https://github.com/qarmin/czkawka/actions/runs/7962237903/artifacts/1257129444

This is brilliant. Thank you so much, you are a lifesaver. Will this fix be updated in the main release version?

qarmin commented 4 months ago

No, because this is not broken. Official binary contains two renderers - opengl(femtovg) and software renderer On linux changing between this two renderers is easy, but on windows we don't know how to do this(but this also should work)

Mewto7 commented 4 months ago

No, because this is not broken. Official binary contains two renderers - opengl(femtovg) and software renderer On linux changing between this two renderers is easy, but on windows we don't know how to do this(but this also should work)

I see. But the changes that you made here that makes it work for me will remain when the next version rolls around, right? That is, the next version will automatically work for me without you having to manually make the changes to it too like you did with this version, right?

Thanks for everything.

ognevny commented 4 months ago

I pushed an update for msys2. you can download the artifact from relevant PR

upd.: https://github.com/msys2/MINGW-packages/actions/runs/7960469969/artifacts/1256653069

Mewto7 commented 4 months ago

I pushed an update for msys2. you can download the artifact from relevant PR

upd.: https://github.com/msys2/MINGW-packages/actions/runs/7960469969/artifacts/1256653069

Thanks. I just tested it. The reference folder issue appears to have been solved. I will run more tests to see if it is completely gone.

Mewto7 commented 4 months ago

No, because this is not broken. Official binary contains two renderers - opengl(femtovg) and software renderer On linux changing between this two renderers is easy, but on windows we don't know how to do this(but this also should work)

Hello. Just to let you know, I found this: https://www.reddit.com/r/opengl/comments/183uk25/im_a_moron_who_doesnt_understand_software_what/kar56kq/

It pointed me to this software: https://fdossena.com/?p=mesa/index.frag

It has something called opengl32.dll that when placed in the same folder as Krokiet.exe, makes it run fine with the release version. The GUI is a little blurry but works perfectly with over 1600 files. I tried with Czkawka and that one didn't work though.

Edit: I sidestepped all this issues by dual booting Lubuntu. It works perfectly there.