qarmin / czkawka

Multi functional app to find duplicates, empty folders, similar images etc.
Other
20.5k stars 665 forks source link

repeatedly confirm deleted file moving to recycle bin #683

Open maxox opened 2 years ago

maxox commented 2 years ago

when check "move deleted files to trash" in settings, I have to click 59 times one by one if im trying to delete 59 files.

qarmin commented 2 years ago

Can you post video of this behaviour? For me dialog shows only once

maxox commented 2 years ago

https://user-images.githubusercontent.com/7052069/164279150-076b99ae-5cc2-4292-8f00-c4a6d518648f.mp4

qarmin commented 2 years ago

It works fine under Linux and probably also Windows 10.

Probably this line https://github.com/qarmin/czkawka/blob/c88d347e0093ba0af47b2fc8714e67cced36cc89/czkawka_gui/src/connect_things/connect_button_delete.rs#L358 Should use delete_all or similar method provided by trash crate

rramstad833 commented 2 years ago

I'm on Windows 10 and I get the same thing -- which sucks -- I had a compare running for several hours today, wanted to look at the files before deleting, enabled move to trash, it found 3153 duplicates, and I told it to delete them. I'm not going to click Yes delete 3153 times.