qarmin / czkawka

Multi functional app to find duplicates, empty folders, similar images etc.
Other
20.11k stars 655 forks source link

Stop button does not immediately stop listing files. #774

Open vi opened 2 years ago

vi commented 2 years ago
  1. Download https://github.com/qarmin/czkawka/releases/download/4.1.0/linux_czkawka_gui.AppImage and run in on Debian
  2. Add root directory to the included list.
  3. Press Search button.
  4. It starts listing files - the counter goes up.
  5. Press Stop button

Expected:

It hides the progress window immediately and stops disk IO.

Actual:

It keeps counting the files for some time, only then stops and returns to the main window.

qarmin commented 2 years ago

Not sure if this is a bug, All remaining atomic tasks(e.g. hashing image) must end correctly. Easier method is to kill process immediately, but this is very discouraged When collecting files to scan I see sometimes lag, because check about exiting from function works rarely, depending on folder structure, so this can be improved

SoftExpert commented 1 year ago

I would say there should be 2 buttons with specific behaviors: