search

qascade / dcr

A PoC framework to orchestrate interoperable Differentially Private Data Clean Room Services using Intel SGX hardware as root of trust.
GNU Affero General Public License v3.0
19 stars 16 forks source link

fix(config): error message on wrong yaml input. #28

Open qascade opened 1 year ago

qascade commented 1 year ago

Description

There is a code in the ParseSpec() function that outputs a better error message if there is an error in input yaml but for some reason, the proper error message is not propagating back.

shraddha761 commented 1 year ago

Want to contribute on this issue request to assign me this issue

qascade commented 1 year ago

Hey, @shraddha761 thanks for your enthusiasm. Currently no issues are being assigned until GSSoC Mentors are onboarded. That should happen by EOD. Then I will start assigning the issues. You can start looking at the code and the spec docs and try to understand the project in the meanwhile.

qascade commented 1 year ago

Hey, @shraddha761 assigning this issue to you.

shraddha761 commented 1 year ago

image hey @qascade what to change in the following line

qascade commented 1 year ago

@shraddha761 To fix this issue, you introduce an error in yaml. Then, you run TestConfig() function. After that the code should return err3 in the above code. That's not happening. Make any necessary changes that do not break any present functionality but gives a proper meaningful error if things go wrong.

shraddha761 commented 1 year ago

@qascade I am not familiar with Go and yml file will you please explain little bit about the changes to be done

qascade commented 1 year ago

@shraddha761 Oh no worries, You should probably get familiar with Go and Yaml first. Added a beginners section in GSSoC_Guidelines.md. Please check that out.

qascade commented 1 year ago

The dcr binary runs a folder containing yaml files and runs a service on them. You should try to understand what the project is at a high level before proceeding to change anything. You may understand that after watching my video and reading the spec doc.

qascade commented 1 year ago

Hey @shraddha761, Any progress on the PR?

shraddha761 commented 1 year ago

@qascade I tried to do some changes but didn't get the proper output

qascade commented 1 year ago

@shraddha761 Let's continue this on discord.

shraddha761 commented 1 year ago

@qascade Yahh sure

qascade commented 1 year ago

Please come by the #dcr channel @shraddha761

sagnik-p commented 1 year ago

This issue has been inactive for a long time Is this resolved? If not, I would like to work on this issue Please assign