search

qascade / dcr

A PoC framework to orchestrate interoperable Differentially Private Data Clean Room Services using Intel SGX hardware as root of trust.
GNU Affero General Public License v3.0
19 stars 16 forks source link

refactor(config): remove repeated code in package config #43

Open qascade opened 1 year ago

qascade commented 1 year ago

Description

While writing the config parser. I had to give in to some level of redundancy for the sake of other high priorities. I want that to be fixed. I want to refactor and refine the config parser and remove unnecessary redundancies.

i-am-yuvi commented 1 year ago

Assign this to me, I am very much familiar with config files in Go

qascade commented 1 year ago

Hey, @i-am-yuvi, assigning this to you. Please make sure that you don't change the structures/types of the abstractions defined in the package config. Also this is not a breaking change, so all the parsing tests should pass. Also extend the TestConfig() function to have more stricter checks as per #35

i-am-yuvi commented 1 year ago

Surely 🚀

qascade commented 1 year ago

@i-am-yuvi Please name the branch refactor.redundancy_removal_config

i-am-yuvi commented 1 year ago

Sure

qascade commented 1 year ago

@i-am-yuvi Any progress on the issue? As per policy, I will have to unassign this issue on 3 days of inactivity.

i-am-yuvi commented 1 year ago

Yes I am working on it

shrey-a-gupta commented 1 year ago

Hi @qascade , I am new to GO language, however I want to learn and contribute to this project and would want to work on this Issue. May you guide me in this issue and assign ?

qascade commented 1 year ago

@shrey-a-gupta you can email me at sksingh2211@gmail.com, we will connect of required. Thanks for taking interest in my project.