qase-tms / qase-java

Qase TMS Java SDK
https://developers.qase.io
Apache License 2.0
17 stars 5 forks source link

Support passing `is_autotest` to TestRun creation to all reporters #74

Closed 1ivliev closed 1 year ago

1ivliev commented 2 years ago

It is possible to set is_autotest (boolean) property https://developers.qase.io/reference/create-run

mbirintsev commented 2 years ago

@1ivliev , good afternoon!

As far as I see, RunCreate already has the parameter.

I suppose you would like to support of passing the property from a CLI. Could you please clarify, if I am right?

Thank you in advance!

1ivliev commented 2 years ago

@mbirintsev Hi! I would like this property to be passed automatically (when creating a run via java integration), because it is a test run attribute.

Screenshot 2022-09-14 at 09 26 14
mbirintsev commented 2 years ago

@1ivliev ,

Thank you for the clarification! I will check and come back with a response (or even an implementation)

mbirintsev commented 2 years ago

@1ivliev ,

Let me share my thoughts about this.

I believe, the most straight and simple way to do this is to default the field to true. Despite we can do it right here, manually, the changes will be outdated right the next (i.e. https://github.com/qase-tms/qase-java/issues/75) io.qase.client.* update (or we will be tied with keeping track on custom updates in the package, that sounds just weird). So, I believe, we could assign the default value over there (the generated code source). However, I am not sure if other reporters (like JS, PHP, or .NET) will not be 'broken'. They do use the source as well, do not they?

If we set the default value in the file, there will be no need to raise the same issue across other language reporters. Moreover, the default value will be "persisted" through the package updates. So, my question is can we modify the file in order to set the default value to a RunCreate request?

Thank you!

mbirintsev commented 2 years ago

If the approach above is not appreciable, there is another one of just creating (e.g) io.qase.api.defaults.RequestDefaults.createDefaultRunCreate() that will serve as a java-local defaults overrider for the configuration.

PS: this approach seems less "correct" because it spreads requests configuration.

sklmx commented 2 years ago

@savkk join the conversation, please. Your thoughts?

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.