Project Feedback - Githubissues

qassisju commented 7 years ago

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

[x] Include a haiku, describing the feelings this product will evoke (with br elements to add new lines where appropriate)
[x] Create and download a sound effect file for what the game will sound like when you win, then include an audio player in the page so users can hear the sample
[x] Include a table comparing which features your game has in comparison to competitors (these competitors may be real or made up)
[x] Include a demo video from YouTube, but featuring a completely unrelated animal being cute (not getting hurt!)

stuartpearman commented 7 years ago

Hey justin, the link didn't seem to work, did you push to Github pages?

qassisju commented 7 years ago

Hey stuart, sorry, I must have forgotten. It should be up now

stuartpearman commented 7 years ago

"Sometimes if you find baby kangaroos you get to keep them" 😆

This looks good Justin! The only thing I would change is your indentation. In this class we're using 2-space indentation. This is just the standard for this class. As you probably know, indentation is a heated topic in the programming world 🔥 . The Writing code for humans to read slide from a previous lesson talks about how to set your default indentation in atom.

qassisju commented 7 years ago

Hi Stuart,

I changed the spacing, now it should be better

stuartpearman commented 7 years ago

Yep, looks good! :shipit:

qassisju / MI-449-SS17-741-html-more-kinds-of-content-OSB7Pe

Project Feedback #1