qaul / qaul.net

Internet Independent Wireless Mesh Communication App
https://qaul.net
GNU Affero General Public License v3.0
496 stars 63 forks source link

updated protobuf files for all languages #574

Closed MathJud closed 11 months ago

MathJud commented 11 months ago

updates all protobuf source files for all languages to current version.

brenodt commented 11 months ago

Hey Math, here's a breakdown of what happened:

Since the last major release of the protoc_plugin for dart, version 21.0.0, the proto file generation breaks our code, as they’ve removed factory constructors from the generated files.

This change is being retracted in favor of having a flag to decide if you want factory constructors or not; see:

As a temporary workaround, we just need to make sure that the version of the plugin installed locally is the version 20.0.1, which can be achieved by:

dart pub global deactivate protoc_plugin
dart pub global activate protoc_plugin 20.0.1

Then, regenerate the proto files by running:

cd rust/libqaul/src/rpc/protobuf_build_scripts
./build_dart.sh

Once the plugin's PR nº 855 lands, we should review to see if we need to change the build command and/or documentation. I already added this task to my backlog.

You can merge this PR now!

MathJud commented 11 months ago

@brenodt Thanks for this investigation & documentation of the findings